See https://github.com/Agoric/agoric-private/issues/312
✔️ When to fix #312?
:➖ in the upcoming CCTP beta release
- already has a lot of scope
- not pertinent to CCTP
:➕ in the release after CCTP beta
:~ in a future unscheduled release
:➖ never, work-around in UI
- #312 was observed when user signed with up to 2.5min between transactions
❓ When to remediate?
: never
+ these are small amounts
:➖ in CCTP beta release
- too much scope already
: in some unscheduled future release
❓ How to remediate #312
: in a core-eval reimburse seats from
settlementAccount basically call disburse()
: send four vtransfer-like events
call
settler.tap.receiveUpcall must clear
mintedEarly entries for original 2 settlements:➖ send something new from OCW
- nothing can cause the existing ADVANCED to transition to DISBURSED
: make the settler robust to outstanding and then do another transfer
- no special core-eval or contract abilities
❓ How to handle batched x/forwarding transfers?
there's no ordering guarantee
applies to forwards and disbursements
:➖ match only exact amounts
+ status quo, no work
- logs an error,
⚠️ tap: minted before observed when the settlement comes, it doesn't match any observation
- LP not paid back
there's no match for the ADVANCED transaction to transition to DISBURSED
:➖ find exact matches first, then fall back to other approaches
+ resolves the large majority of transactions
- a more holistic approach might (?) find more matches
- more complicated to have multiple paths
:➕ key by destination and consume from settlement amount
remove 'amount' from
pendingSettleTxs key remove 'amount' from
mintedEarly key and change value to array of bigints❓ how to prioritize to DISBURSE/FORWARD of pending?
both paths need the same logic
:~ descending on amount
+ recipient gets their money faster (weighted)
+ equal amounts are equivalent
no distinction necessary
: in observed order
+ likely what the user expects
- what they expect does not imply what they want most
- no guarantees the incoming order matches
- recipient cares less about the order of the transactions than getting the most of their money sooner